On 05/02/11 07:30, Jim Meyering wrote:
> Dmitry V. Levin wrote:
>> On Fri, Feb 04, 2011 at 08:20:39PM +0100, Jim Meyering wrote:
>>> This is to announce coreutils-8.10, a stable release.
>>>
>>> There have been some minor bug fixes, along with two new features.  The
>>> join feature is enabled via a new option, "-o auto".  The cp feature makes
>>> copying sparse files much more efficient on several common file systems.
>>> It takes advantage of a feature that was introduced in linux-2.6.27.
>>> The improvement affects the default code path, so if you're looking
>>> for risk potential, this is it.  It uses the feature if available,
>>> and otherwise resorts to using the old, less-efficient copying code.
>>
>> tests/cp/fiemap-perf fails with EFBIG on tmpfs:
>> $ truncate -s1T f
>> truncate: failed to truncate `f' at 1099511627776 bytes: File too large
>>
>> Reducing the size from 1T to 256G makes the test pass.
> 
> Thanks for the report.
> The current df-based guard for the cp/FIEMAP tests
> is a kludge^W heuristic that will soon be replaced by
> Pádraig's python-based test:
> 
> http://thread.gmane.org/gmane.comp.gnu.coreutils.general/821/focus=839

Yep, just did that, and got a couple of failures for sparse-fiemap
on and ext3 and loopback ext4 file systems.
On a very quick glance, I think cp is OK and that the filefrag
matching is a bit brittle.
Attached are filefrag outputs.

$ rpm -q kernel e2fsprogs
kernel-2.6.35.10-72.fc14.i686
e2fsprogs-1.41.12-6.fc14.i686

cheers,
Pádraig.
Filesystem type is: ef53
Filesystem cylinder groups is approximately 295
File size of j2 is 63488 (16 blocks, blocksize 4096)
 ext logical physical expected length flags
   0       0  8839042               1 merged
   1       1  8839045  8839042      3 merged
   2       4  8839058  8839047      6 merged
   3      10  8839066  8839063      2 merged
   4      12  8839069  8839067      4 merged,eof
j2: 5 extents found, perfection would be 1 extent
Filesystem type is: ef53
Filesystem cylinder groups is approximately 295
File size of j1 is 63488 (16 blocks, blocksize 4096)
 ext logical physical expected length flags
   0       0  8819898               1 merged
   1       1  8819902  8819898      1 merged
   2       2  8837851  8819902      4 merged
   3       6  8839016  8837854      6 merged
   4      12  8839033  8839021      2 merged
   5      14  8839037  8839034      1 merged
   6      15  8839041  8839037      1 merged,eof
j1: 7 extents found, perfection would be 1 extent
Filesystem type is: ef53
File size of j2 is 2048 (2 blocks, blocksize 1024)
 ext logical physical expected length flags
   0       0        0               2 unknown,delalloc,eof
j2: 1 extent found
Filesystem type is: ef53
File size of j1 is 2048 (2 blocks, blocksize 1024)
 ext logical physical expected length flags
j1: 1 extent found

Reply via email to