Pádraig Brady wrote: > Trivial item removed from my TODO list > >>From 282ec20de8d715db3ae834f8282eea5488d4c20b Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?P=C3=A1draig=20Brady?= <[email protected]> > Date: Tue, 10 May 2011 08:14:16 +0100 > Subject: [PATCH] tests: refactor more tests to use mkfifo_or_skip_ > > * tests/cp/existing-perm-race: s/mkfifo/mkfifo_or_skip_/ > * tests/cp/file-perm-race: Likewise. > * tests/cp/parent-perm-race: Likewise. > * tests/cp/special-f: Likewise. > * tests/dd/reblock: Likewise. > * tests/ls/file-type: Likewise. > * tests/misc/cat-buf: Likewise. > * tests/misc/mknod: Likewise. > * tests/misc/printf-surprise: Likewise. > * tests/misc/selinux: Likewise. > * tests/misc/sort-spinlock-abuse: Likewise. > * tests/misc/stdbuf: Likewise. > * tests/misc/tac-continue: Likewise. > * tests/init.cfg: Improve the error message when skipping. ... > -mkfifo fifo || > - skip_test_ "fifos not supported" > +mkfifo_or_skip_ fifo ... > -mkfifo fifo || > - skip_test_ "fifos not supported" > +mkfifo_or_skip_ fifo ... > - mkfifo $attr/fifo || > - skip_test_ "fifos not supported" > + mkfifo_or_skip_ $attr/fifo ... > -mkfifo fifo || > - skip_test_ "fifos not supported" > +mkfifo_or_skip_ fifo
... Thanks. That looks fine.
