Re: [PATCH] tests: cp/sparse-fiemap: use "seq 99q" in place of "head -99"

[Bernhard Voelker]

On 06/21/2011 11:02 AM, Jim Meyering wrote:

Bernhard Voelker wrote:

There was still an obsolete use of "head -[1-9]" in tests.
The following patch replaces it.

Thanks, but actually no change is required there, since when running the
tests, we're guaranteed to be using coreutils' own version of "head".
By contrast, the just-fixed use in init.sh had no such protection, since
init.sh is used in other projects.

However, if you'd like to adjust your patch to make the test
use head -n99 instead (more readable than sed 99q and more future-proof
than "head -99", in case we stop supporting head -N), I'll apply it.

Thanks. The new patch is attached.

Have a nice day,
Berny

>From 7f7abf823fe8341a13b016532e1e4819c6cf1b93 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <m...@bernhard-voelker.de>
Date: Tue, 21 Jun 2011 10:10:39 +0200
Subject: [PATCH] tests: cp/sparse-fiemap: use "head -n99" in place of "head -99"

* tests/cp/sparse-fiemap: Use "head -n99" in place of "head -99".
The latter is officially obsolete.
---
 tests/cp/sparse-fiemap |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/cp/sparse-fiemap b/tests/cp/sparse-fiemap
index 3d34077..37d8ea7 100755
--- a/tests/cp/sparse-fiemap
+++ b/tests/cp/sparse-fiemap
@@ -106,7 +106,7 @@ for i in $(seq 1 2 21); do
         || {
              warn_ ignoring filefrag-reported extent map differences
              # Show the differing extent maps.
-             head -99 ff1 ff2
+             head -n99 ff1 ff2
            }
     fi
     test $fail = 1 && break 2
-- 
1.7.3.4