On 25/07/11 15:00, Jim Meyering wrote: > Thanks for the review. > Factoring out that function is definitely worth doing. > However, I'd prefer to keep that clean-up change separate > from the bug-fixing one. Would you please add a comment for > the new function? Maybe something as simple as this: > > /* Create a hard link DST_NAME to SRC_NAME, honoring the REPLACE and > VERBOSE settings. Return true upon success. Otherwise, diagnose > the failure and return false. */
OK I'll cleanup and apply the refactoring after yours. cheers, Pádraig.
