I have just had this commit hook mistakenly reject a commit log due to a git-generated comment line that was longer than 72. Obviously, those should be exempted:
>From b29658ee8456c209aef5d7b9534b9e2d575fc29d Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Wed, 23 Nov 2011 09:02:51 +0100 Subject: [PATCH] scripts: commit-msg: tweak 72-column test to avoid a false-positive * scripts/git-hooks/commit-msg: Don't warn about a line that is longer than 72 if it is a comment. Git-generated comments would occasionally trigger this. --- scripts/git-hooks/commit-msg | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg index 7d0891e..f85eea8 100755 --- a/scripts/git-hooks/commit-msg +++ b/scripts/git-hooks/commit-msg @@ -101,7 +101,7 @@ sub check_msg($$) # Limit line length to allow for the ChangeLog's leading TAB. foreach my $line (@line) { - 72 < length $line + 72 < length $line && $line =~ /^#/ and return 'line longer than 72'; } -- 1.7.8.rc3.23.ge14d6
