Bernhard Voelker wrote: > On 12/01/2011 01:40 AM, Pádraig Brady wrote: >> On 12/01/2011 12:17 AM, Bernhard Voelker wrote: >>> As a replacement for my previously proposed patch: >>> "[PATCH] tests: adjust PATH to include /usr/sbin for filefrag-using tests" >>> (see http://lists.gnu.org/archive/html/coreutils/2011-11/msg00086.html), >>> and after some confusion in the discussion, the following patch adds >>> /sbin and /usr/sbin generally for all tests. >> >> I agree with this, and the patch looks good. >> A separate sbin is daft anyway, so best to avoid it like this. > > Thanks. > > I was unsure about /usr/local/sbin, but in the end I decided > to leave it out. Do you think it's worth adding?
No. If someone has /usr/local/sbin, yet it's not in their path, adding it may constitute a security problem. At the very least, it would be an unannounced policy change. And then you'd have to decide whether it comes before or after other /sbin directories. I'm glad you left it out.
