All, Working on dd new features, I found out that a do/while statement wasn't respecting the HACKING coding standard.
I attached the patch which fix this. Cheers, Jérémy ---
>From c34ba70d5bbdb91fce01a58bef1d61df7b191880 Mon Sep 17 00:00:00 2001 From: Jeremy Compostella <[email protected]> Date: Sun, 5 Feb 2012 17:53:55 +0100 Subject: [PATCH] dd: add braces as requested by HACKING coding standard Braces was missing for this do/while statement. Signed-off-by: Jeremy Compostella <[email protected]> --- src/dd.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/dd.c b/src/dd.c index 8c687b3..9b18a72 100644 --- a/src/dd.c +++ b/src/dd.c @@ -1807,12 +1807,14 @@ dd_copy (void) memset (obuf, 0, output_blocksize); do - if (iwrite (STDOUT_FILENO, obuf, output_blocksize) - != output_blocksize) - { - error (0, errno, _("writing to %s"), quote (output_file)); - quit (EXIT_FAILURE); - } + { + if (iwrite (STDOUT_FILENO, obuf, output_blocksize) + != output_blocksize) + { + error (0, errno, _("writing to %s"), quote (output_file)); + quit (EXIT_FAILURE); + } + } while (--write_records != 0); } } -- 1.7.2.5
