Eric Blake wrote: > On 04/30/2012 07:08 AM, Jim Meyering wrote: >> Here's a new syntax-check rule (patch 3/3). >> 1 and 2 fix violations so that the new check passes. >> >> For now, this is only in coreutils (grep had only two violations), >> but given the long list of violations in gnulib's lib/ directory, >> it may not be generally appealing enough to be added to gnulib's maint.mk: >> >> $ git grep -lE '(. [-/+]|&&|\|\|)$' lib > > Is it worth adding some more operators, such as *, ^, &, and |? > > (. [-/+*^]|&&?|\|\|?)$
I mentioned why "*" is excluded in the cfg.mk comment (too many false positives for "TYPE *"), and get the feeling that the cost/benefit ratio is too high for the others, since they are so much less common. For example, the commenting style in fmt.c provokes many false positives for "|".
