On 07/03/2012 08:19 PM, Jim Meyering wrote: > Inspired by the EXIT_FAILURE problem Pádraig spotted > and that Paul just fixed, I wrote a new syntax-check rule > to help avoid that sort of problem. The following programs > must avoid most new uses of EXIT_FAILURE: > > chroot.c > env.c > expr.c > ls.c > nice.c > nohup.c > printenv.c > setuidgid.c > stdbuf.c > system.h > timeout.c > tty.c > > This new syntax-check rule caught a minor problem in > our helper setuidgid (not installed) and I fixed another > minor problem in the vicinity (dead code on error path). > > Here are the two patches:
Nice one. That check is certainly warranted. Both patches look fine from a quick glance. cheers, Pádraig.
