[PATCH 2/2] doc: tweak 'lcov' in HACKING

[Bernhard Voelker]

splitting the discussion about the 2 patches ...

On 12/13/2012 08:29 PM, Assaf Gordon wrote:
> [...]
> The second changes parameters for 'lcov' example - the current parameters
> produce wrong output (the source files are not found, with LCOV version 1.9 ).

Thanks.

> [PATCH 2/2] doc: tweak 'lcov' in HACKING

I also noticed the lcov issue recently, but didn't find the time
to fix HACKING. Furthermore, I'm not sure if lcov-1.9 is the reason
for the problem - I think it worked some time ago ... and according
to 'rpm -q -changelog lcov', I already have 1.9 since about Jan or
Feb 2011.

It think the reason might be the new non-recursive build system.

And furthermore, the second lcov call still fails here:

  $ lcov -t coreutils -q -d src -b `pwd` -o src.lcov -c
  <built-in>:cannot open source file
  geninfo: ERROR: cannot read <built-in>.gcov!

Don't you get that, too?

I had a look at the Hydra recipe which just removes the offending files:
http://git.sv.gnu.org/cgit/hydra-recipes.git/tree/coreutils/release.nix

    coverage =
      pkgs.releaseTools.coverageAnalysis {
        name = "coreutils-coverage";
        src = jobs.tarball;
        configureFlags = [ "--enable-install-program=arch,hostname" ];
        buildInputs = buildInputsFrom pkgs;
        postCheck =
          # Remove the file that confuses lcov.
          '' rm -fv 'src/<built-in>.'*
             rm -fv src/getlimits.gc*
          '';
        inherit meta;
      };

Have a nice day,
Berny