Pádraig Brady wrote:
...
> I'll push the attached (complete with new test and doc adjustments) soon.
...

Nice.  I was going to say it looked impeccable,
but then noticed a nit at the end of the test.
Thanks!

> diff --git a/tests/readlink/multi.sh b/tests/readlink/multi.sh
...
> +readlink link1 link1 || fail=1
> +readlink link1 link2 && fail=1
> +readlink link1 link2 link1 && fail=1
> +readlink -m link1 link2 || fail=1
> +
> +printf "/1\0/1\0" > exp
> +readlink -m --zero /1 /1 > out

I think you want "|| fail=1" after each of the above lines.

> +compare exp out || fail=1
> +
> +Exit $fail

Reply via email to