On 01/27/2013 05:51 PM, Bernhard Voelker wrote:
On 01/26/2013 11:12 AM, Ondrej Oprala wrote:
No worries, your approach looks good.
Thanks. Pushed:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=bb116d35
I fixed the following before pushing:
- devlist = xmalloc (sizeof devlist);
+ devlist = xmalloc (sizeof *devlist);
and now valgrind is silenced again. ;-)
Looking at this in detail is still at the end of my TODO list.
However here are some things I noticed in a 1 min glance:
udev is a separate file system here, which now seems not displayed?
$ df --version
df (GNU coreutils) 8.10
$ df | grep /dev$
udev 1454732 0 1454732 0% /dev
$ grep udev /proc/mounts
udev /dev devtmpfs rw,...
$ src/df
Filesystem 1K-blocks Used Available Use% Mounted on
/dev/sdb2 13102208 11843544 1125596 92% /
tmpfs 1464412 15832 1448580 2% /dev/shm
tmpfs 1464412 1824 1462588 1% /run
tmpfs 1464412 0 1464412 0% /sys/fs/cgroup
tmpfs 1464412 0 1464412 0% /media
/dev/sdb1 100791728 70450868 25220860 74% /home
Also do we need to treat rootfs specially in the code now?
thanks,
Pádraig.
