On 02/10/2013 11:34 AM, Alexey Potehin wrote: > Hello people! > > This is path for chmod speedup (chmod only if newmode != oldmode), in > attach too:
I'm not sure this is a good idea. chmod() may have side effects such as resetting ACLs, even when the struct stat.st_mode bits are unchanged; so omitting the call into the kernel would unintentionally miss out on those side effects. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
