On 02/11/2013 11:55 AM, Pádraig Brady wrote:
This is another snapshot mainly to roll up translations.
We plan to release coreutils 8.21 this Thursday.
coreutils snapshot:
http://pixelbeat.org/cu/coreutils-ss.tar.xz 5.1 MB
http://pixelbeat.org/cu/coreutils-ss.tar.xz.sig
http://pixelbeat.org/cu/coreutils-8.20.119-54cdb0.tar.xz
changes since snapshot 8.20.113-1f1f4:
Benno Schulenberg (1):
doc: standardize helptext of numfmt and slice into single options
Bernhard Voelker (1):
maint: avoid running check-root tests in gnulib
Pádraig Brady (4):
tests: skip numfmt grouping tests on some systems
tests: tail-2/inotify-rotate: fix a false failure on NFS
maint: consolidate developer debug messages
doc: improve the numfmt man page format
After lots of `make checks` ...
All tests passed on these GNU/Linux systems:
Intel Pentium 4 (2660 MHz); GNU/Linux 3.6.8-2.fc17.i686.PAE (Fedora release
17 (Beefy Miracle))
AMD64 Opteron 850, 8GB RAM; GNU/Linux Red Hat Enterprise Linux 5.8 (Tikanga)
AMD64 Opteron, 8GB RAM; Red Hat Enterprise Linux AS release 6.3 (Santiago)
AMD64 Opteron 2220, 24GB RAM; Ubuntu 9.10 (karmic)
Dell PowerEdge 3250: Intel Itanium-2 (1400 MHz) (2 CPUs, 4GB RAM); GNU/Linux
2.6.18-194.el5 (Red Hat Enterprise Linux Server release 5.5 (Tikanga))
Sun Blade 1500 (1062 MHz TI UltraSparc IIIi (Jalapeno), 1GB RAM);
GNU/Linux 3.2.1-gentoo-r2 (Gentoo 2.0.3)
DEC Alpha 4100-5/466 (4 21164 EV5 CPUs, 466 MHz, 2GB RAM); GNU/Linux
2.6.34-gentoo-r1 (Gentoo Base System release 2.0.3)
Apple PowerMac G5 (4 2500 MHz PPC970MP CPUs, 8GB RAM); GNU/Linux
2.6.39-gentoo-r3 (Gentoo Base System release 2.0.3)
Apple PowerMac G4 (2 500 MHz PowerPC 7400 CPUs, 256MB RAM); GNU/Linux
2.6.39-gentoo-r3 (Gentoo Base System version 2.0.3)
I drilled a bit deeper into these other GNU/Linux systems:
GNU/Linux on power7 (ppc64)
coreutils
442 passed
96 skipped
gnulib
307 passed
10 skipped
GNU/Linux on niagra (sparc64)
coreutils
419 passed
119 skipped
gnulib
283 passed
34 skipped
GNU/Linux on parisc
coreutils
420 passed
118 skipped
gnulib
hung at test-lock
GNU/Linux on mips64
coreutils
422 passed
116 skipped
gnulib
287 passed
30 skipped
Solaris 10 is looking fairly good too:
Sun Ultra Enterprise 2900 (4 dual/core CPUs, 1050 MHz UltraSPARC-IV, 16GB);
Solaris 10
I tried another similar system but running from /tmp
coreutils
398 passed
8 failed
All due to cp -a giving errno 89 on dirs on tmpfs
> src/df --o=fstype,source,target .
Type Filesystem Mounted on
tmpfs swap /tmp
> mkdir dir
> src/cp -a dir dir2
src/cp: preserving permissions for 'dir2': Operation not applicable
132 skipped
However on this system I got a link failure:
CC: Sun C++ 5.10 SunOS_sparc 128228-11 2010/10/14
link failure
Undefined symbol dev_debug in src/chroot.o
I guess this will happen on linkers that don't ignore unused functions.
So I'll apply the *attached patch* as a workaround.
BSD isn't too bad either:
AMD64 Opteron, 8GB RAM); FreeBSD 8.1-RELEASE
FAIL: tests/install/install-C.sh
FAIL: tests/cp/nfs-removal-race.sh
AMD64 Opteron, 8GB RAM); OpenBSD 5.1 GENERIC#160 i386
FAIL: tests/misc/sort-compress.sh
src/seq -w 2000 | src/tac > in
src/sort -S 1k --compress-program=gzip in # slow but ok
PATH=.:$PATH src/sort -S 1k --compress-program=gzip
src/sort: read failed: /tmp/sortDWKaGM: Interrupted system call
FAIL: tests/install/install-C.sh
FAIL: tests/cp/nfs-removal-race.sh
Maybe due to nfs issues as tests done on nfs
FAIL: tests/du/threshold.sh
The du/threshold.sh failure is new and should be
addressed by the *attached patch*.
FAIL: tests/ls/abmon-align.sh
This due to:
LANG=fr_FR src/wc
src/wc:/usr/local/lib/libintl.so.6.0: undefined symbol
'libiconv_set_relocation_prefix'
lazy binding failed!
Segmentation fault (core dumped)
So then on to build failures. I don't think there is anything new
at issue below, so I don't see these as release blockers...
This failure seemed intermittent, on both Fedora 17 and RHEL 5.8.
More investigation needed:
"lib/getfilecon.c", line 36: warning: undefined or missing type for:
security_context_t
CC: Sun C++ 5.11 SunOS_i386 2010/08/13
CC lib/backupfile.o
"lib/xalloc.h", line 217: reference to static identifier "xnmalloc" in
extern inline function
c99: acomp failed for lib/backupfile.c
cc (GCC) 4.4.6 20120305 (Red Hat 4.4.6-4)
CC lib/set-mode-acl.o
In file included from ./lib/time.h:39:0, from ./lib/sys/stat.h:44,
from lib/acl.h:21, from lib/set-mode-acl.c:24:
/usr/include/time.h:226:5: error: unknown type name '__locale_t'
In file included from ./lib/time.h:367:0, from ./lib/sys/stat.h:44,
from lib/acl.h:21, from lib/set-mode-acl.c:24:
./lib/sys/time.h:378:8: error: redefinition of 'struct timeval'
/usr/include/bits/time.h:75:8: note: originally defined here
cc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-54)
CC lib/areadlink.o
/tmp/ccS7lf5E.s: Assembler messages:
/tmp/ccS7lf5E.s:30: Error: symbol `pread64' is already defined
SGI O2 R10000-SC (150 MHz); IRIX 6.5
CC MIPSpro Compilers: Version 7.30
CC lib/set-mode-acl.o
cc-1143 c89: ERROR File = ///usr/include/sys/time.h, Line = 194
Declaration is incompatible with
"int rpl_gettimeofday(struct timeval *restrict, void *restrict)"
(declared at line 398 of "./lib/sys/time.h").
extern int gettimeofday(struct timeval *,...);
^
SGI Origin/200-4 (180 MHz) (4 R10000 CPUs); IRIX 6.5
CC MIPSpro Compilers: Version 7.3.1.3m
CC lib/spawni.o
lib/spawni.c: In function `gl_posix_spawn_internal':
lib/spawni.c:186: warning: implicit declaration of function `sigprocmask'
lib/spawni.c:202: error: `NSIG' undeclared (first use in this function)
lib/spawni.c:202: error: (Each undeclared identifier is reported only once
lib/spawni.c:202: error: for each function it appears in.)
thanks,
Pádraig.
>From 302564444383169087fbbec36983789abbac9aa5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <p...@draigbrady.com>
Date: Thu, 14 Feb 2013 02:32:22 +0000
Subject: [PATCH] build: avoid link failure in devmsg() on older linkers
On linkers that don't remove unused functions,
there will be a reference to a missing dev_debug symbol
in the devmsg() function. So for now ...
* src/system.h: ... move devmsg() from here ...
* src/numfmt.c: ... to here, and document future cleanup.
* src/factor.c: Likewise.
---
src/factor.c | 18 +++++++++++++++++-
src/numfmt.c | 21 ++++++++++++++++++---
src/system.h | 15 ---------------
3 files changed, 35 insertions(+), 19 deletions(-)
diff --git a/src/factor.c b/src/factor.c
index df3d7a0..8f1542a 100644
--- a/src/factor.c
+++ b/src/factor.c
@@ -687,7 +687,23 @@ verify (W <= WIDE_UINT_BITS);
/* debugging for developers. Enables devmsg().
This flag is used only in the GMP code. */
-bool dev_debug = false;
+static bool dev_debug = false;
+
+/* Like error(0, 0, ...), but without an implicit newline.
+ Also a noop unless the global DEV_DEBUG is set.
+ TODO: Replace with variadic macro in system.h or
+ move to a separate module. */
+static inline void
+devmsg (char const *fmt, ...)
+{
+ if (dev_debug)
+ {
+ va_list ap;
+ va_start (ap, fmt);
+ vfprintf (stderr, fmt, ap);
+ va_end (ap);
+ }
+}
/* Prove primality or run probabilistic tests. */
static bool flag_prove_primality = true;
diff --git a/src/numfmt.c b/src/numfmt.c
index 9a321d6..8c21c2b 100644
--- a/src/numfmt.c
+++ b/src/numfmt.c
@@ -190,13 +190,28 @@ static uintmax_t header = 0;
error (similar to sort's debug). */
static bool debug;
-/* debugging for developers. Enables devmsg(). */
-bool dev_debug = false;
-
/* will be set according to the current locale. */
static const char *decimal_point;
static int decimal_point_length;
+/* debugging for developers. Enables devmsg(). */
+static bool dev_debug = false;
+
+/* Like error(0, 0, ...), but without an implicit newline.
+ Also a noop unless the global DEV_DEBUG is set.
+ TODO: Replace with variadic macro in system.h or
+ move to a separate module. */
+static inline void
+devmsg (char const *fmt, ...)
+{
+ if (dev_debug)
+ {
+ va_list ap;
+ va_start (ap, fmt);
+ vfprintf (stderr, fmt, ap);
+ va_end (ap);
+ }
+}
static inline int
default_scale_base (enum scale_type scale)
diff --git a/src/system.h b/src/system.h
index 6c310ad..1677999 100644
--- a/src/system.h
+++ b/src/system.h
@@ -649,21 +649,6 @@ stzncpy (char *restrict dest, char const *restrict src, size_t len)
return dest;
}
-/* Like error(0, 0, ...), but without an implicit newline.
- Also a noop unless the global DEV_DEBUG is set. */
-extern bool dev_debug;
-static inline void
-devmsg (char const *fmt, ...)
-{
- if (dev_debug)
- {
- va_list ap;
- va_start (ap, fmt);
- vfprintf (stderr, fmt, ap);
- va_end (ap);
- }
-}
-
#ifndef ARRAY_CARDINALITY
# define ARRAY_CARDINALITY(Array) (sizeof (Array) / sizeof *(Array))
#endif
--
1.7.7.6
>From 5dd7f9f0f5d4ec45f654f9dc9a887a5f3f76e759 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <p...@draigbrady.com>
Date: Thu, 14 Feb 2013 04:27:34 +0000
Subject: [PATCH] tests: avoid non portable sed use of \t
* tests/du/threshold.sh: use `cut` rather than
sed to avoid using the non portable \t which
fails on sed on openbsd 5 at least.
Also remove a redundant call to `tr` and avoid
explicit setting of LANG=C which is done globally.
---
tests/du/threshold.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/du/threshold.sh b/tests/du/threshold.sh
index 95e9aed..ee5217d 100644
--- a/tests/du/threshold.sh
+++ b/tests/du/threshold.sh
@@ -121,14 +121,14 @@ dutest ()
if [ "$exp" = "" ] ; then
touch exp
else
- printf "%s " $exp | tr ' ' "\n" > exp
+ printf "%s\n" $exp > exp
fi
rc=0
du -B1 $args a > out1 2>&1 || { cat out1 ; rc=1 ; }
# Remove the size column and sort the output.
- sed 's/^[0-9]*\t//' < out1 | LANG=C sort -o out || framework_failure_
+ cut -f2- out1 | sort > out || framework_failure_
compare exp out || { cat out1 ; rc=1 ; }
return $rc
--
1.7.7.6
