On 02/16/2013 10:31 AM, Bernhard Voelker wrote:
Hi Stefano,
On 02/16/2013 07:16 AM, Stefano Lattarini wrote:
Hi Bernhard.
On 02/15/2013 04:54 PM, Bernhard Voelker wrote:
Strange, when I provoke a 2nd re_edit() by giving a bad commit
message, then "Vim" is used as $editor instead my $GIT_EDITOR
(which has been successfully used in the first place).
Have you re-run ./bootstrap to cause the updated hook to be
installed in .git/hooks?
I only updated .git/hooks/commit-msg without any "make" or
"bootstrap". And this is what I did:
In an xterm:
$ ls >> src/df.c
$ git add src/df.c
$ git commit
Then my $GIT_EDITOR opens as expected.
I enter "hello world." as commit message and quit.
==> Then, vi is started in that xterm with the complaint
line at the top to fix the commit message.
After that, my xterm is totally messed up and only "reset"
Yes I see that too, though the messed up xterm
was an issue before this patch.
commit-msg also needs to be updated to allow
easily aborting the commit. A common way to do
that is to write an empty commit message.
thanks,
Pádraig.
