On Mon, Jun 3, 2013, at 18:01, Jarkko Sakkinen wrote: > Hi > > On Mon, Jun 3, 2013, at 13:53, Pádraig Brady wrote: > > On 06/03/2013 10:19 AM, Jarkko Sakkinen wrote: > > > Enable showing of file SMACK labels with -Z command-line switch. > > > > > > * src/ls.c (gobble_file): Output the smack context if available. > > > * src/ls.c: New function getsmackcon_cache() for grabbing SMACK label. > > > > Better thanks. > > Though you only addressed one aspect of my previous feedback. > > Please supply further adjustments as per preview review. > > No worries, I'll iterate as long as needed :) I think I addressed > actually three things: indentation issue, enumeration and separate > function for getting smack context. I'll check your review *carefully* > again and fix the rest. Thanks.
OK, I understand what you're saying. There were at least two clomsy indentation mistakes and I hadn't fixed conditional statement. Sorry about those. Actually now that SMACK context is grabbed in its own function I can also considerably simplify the patch. So except much less intrusive revision 3.. > > > > > thanks, > > Pádraig. > > > > /Jarkko /Jarkko
