On 11/29/2013 09:16 AM, Bernhard Voelker wrote: > Hi Padraig, > > shouldn't we include these into the upcoming release? > > $ git grep -n 'FIXME.*2013' | cat -n > 1 src/df.c:246: MEGABYTES_OPTION /* FIXME: remove long opt in > Aug 2013 */
This has been undocumented for 12 years, warned about for a year, and unused in debian at least: http://codesearch.debian.net/search?q=df.*megabytes Nuke it please. > 2 src/extent-scan.c:32: FIXME: remove in 2013, or whenever > we're pretty confident The kernel never got this fix unfortunately. Therefore the FIXME comment should be removed. > 3 src/realpath.c:54: {"strip", no_argument, NULL, 's' /* FIXME: > deprecate in 2013 or so */}, Actually debian still removes realpath(1) from coreutils in preference for the separate realpath package. I must log a bug for that. So we can't remove yet. In any case --strip is another way to think about the operation, so I'd be inclined to leave it in indefinitely. So please just remove the FIXME comment. > I'm not sure about #2, but I'd go for #1 and #3. > > And there's an even older one regarding > "info coreutils 'General output formatting'": > > doc/coreutils.texi:7651:@c FIXME: remove in 2009, if Apple Terminal has > been fixed for long enough. > > I've no idea about Apple Terminals. Do you know? No idea. Test case is here if anyone can try: http://lists.gnu.org/archive/html/bug-coreutils/2007-01/msg00093.html cheers, Pádraig.
