On 02/26/2014 07:36 AM, Bernhard Voelker wrote: > * src/shuf.c (main): s/No/no/, introduced by commit g9f60f37.
I adjusted the commit reference slightly, and also included an adjustment to NEWS to make it clear that this was not a regression. I'll push the attached if you're ok with it. thanks, Pádraig
>From 5475e6083f46a2f9f7ccf4173f391bf518421523 Mon Sep 17 00:00:00 2001 From: Bernhard Voelker <[email protected]> Date: Wed, 26 Feb 2014 08:36:50 +0100 Subject: [PATCH] shuf: convert error diagnostic to lowercase * src/shuf.c (main): s/No/no/, introduced by commit v8.22-25-g9f60f37. * NEWS: Also adjust the NEWS for that recent commit to make it clear this was new bug rather than a regression. Prompted by the syntax-check rule sc_error_message_uppercase --- NEWS | 4 ++-- src/shuf.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 2df246d..be8311f 100644 --- a/NEWS +++ b/NEWS @@ -22,8 +22,8 @@ GNU coreutils NEWS -*- outline -*- it would display an error, requiring --no-dereference to avoid the issue. [bug introduced in coreutils-5.3.0] - shuf -r no longer dumps core if the input is empty. - [bug introduced in coreutils-8.22] + shuf --repeat no longer dumps core if the input is empty. + [bug introduced with the --repeat feature in coreutils-8.22] ** New features diff --git a/src/shuf.c b/src/shuf.c index 2a91072..6ae0755 100644 --- a/src/shuf.c +++ b/src/shuf.c @@ -581,7 +581,7 @@ main (int argc, char **argv) else { if (n_lines == 0) - error (EXIT_FAILURE, 0, _("No lines to repeat")); + error (EXIT_FAILURE, 0, _("no lines to repeat")); if (input_range) i = write_random_numbers (randint_source, head_lines, lo_input, hi_input, eolbyte); -- 1.7.7.6
