On 06/02/2014 07:25 AM, Bernhard Voelker wrote: > I noticed the following, missing "require_built_ chroot" > in another test when looking through latest chroot changes. > > As an alternative, we could directly add the check to > the 'print_ver_' function. > WDYT? > > Have a nice day, > Berny > > >>From 7c16e0a55a69ac5c3b75fc2b2f8f44402893c4a3 Mon Sep 17 00:00:00 2001 > From: Bernhard Voelker <[email protected]> > Date: Mon, 2 Jun 2014 08:05:06 +0200 > Subject: [PATCH] tests: skip chroot test if program not built > > * tests/misc/chroot-credentials.sh: Require chroot program to be built. > --- > tests/misc/chroot-credentials.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/misc/chroot-credentials.sh > b/tests/misc/chroot-credentials.sh > index d50704c..54dff43 100755 > --- a/tests/misc/chroot-credentials.sh > +++ b/tests/misc/chroot-credentials.sh > @@ -20,6 +20,7 @@ > . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src > print_ver_ chroot > > +require_built_ chroot > require_root_ > > grep '^#define HAVE_SETGROUPS 1' "$CONFIG_HEADER" >/dev/null \ >
It's already incorporated in require_root_ so this shouldn't be required I think. thanks, Pádraig.
