On 08/21/2014 09:09 PM, Yurij Goncharuk wrote: > Hello! > > I still research code from 'coreutils' and find place where put some benefits. > I offer replace block for setting quoting style(watching environment variable > QUOTING_STYLE) with function as comment 'FIXME: put this in a function.' in > src/ls.c. I don't sure about function name and required prototype, but my > vision I introduce in patch. I successfully test this block throw tests in > tests/ls/*.sh and 'make syntax-check'.
I pushed a variant of that since it does remove a FIXME comment. There didn't seem to be an opportunity to conditionally call this new function, so since it's not a functional change, I adjusted the commit summary to: maint: .... I also pulled the getenv() call inside the function since the error message within the function referred to env variables, and the env variable wasn't needed outside the function. thanks! Pádraig.
