On 05/11/2015 03:53 PM, Pádraig Brady wrote: > The 5 patch set is attached.
Really nice work! Minor nits: > Subject: [PATCH 3/5] tests: cleanup background processes upon interruption tests/tail-2/append-only.sh: The cleanup_ function would only kill the last tail background process. I suggest calling cleanup_ inside the for-loop. > Subject: [PATCH 4/5] tail: fix inotify startup races > --- /dev/null > +++ b/tests/tail-2/inotify-race2.sh ... > +# Run "tail -f file", stopping to replace with a new file before s/-f/-F/ > Subject: [PATCH 5/5] tail: consistently output all data for truncated files ... > (recheck): Add a FIXME for the related issue where tail may loses s/loses/lose/ > --- /dev/null > +++ b/tests/tail-2/truncate.sh ... > + # Wait up to 12.7s for tail to start > + echo x > $n + echo x ./tests/tail-2/truncate.sh: line 43: $n: ambiguous redirect 'n' is not set - I guess this is a testing reminiscence? Thanks & have a nice day, Berny
