On Thu, Jul 2, 2015 at 9:59 AM, Pádraig Brady <[email protected]> wrote: ... > BTW if changing gl_shell_test_script_, what do you think about > the change to reject shells that don't support 'local'? > > diff --git a/tests/init.sh b/tests/init.sh > index 9f403c5..c4dfadd 100755 > --- a/tests/init.sh > +++ b/tests/init.sh > @@ -150,6 +150,7 @@ fi > # ? - not ok > gl_shell_test_script_=' > test $(echo y) = y || exit 1 > +f() { local v=1; }; f || exit 1 > score_=10 > if test "$VERBOSE" = yes; then > test -n "$( (exec 3>&1; set -x; P=1 true 2>&3) 2> /dev/null)" && score_=9
I like it, and it looks reasonable/safe. It feels like the shells that it will reject must have become irrelevant a few years ago. You're welcome to push that, perhaps with an added comment.
