On 01/09/15 17:38, Jim Meyering wrote: > On Tue, Sep 1, 2015 at 6:46 AM, Pádraig Brady <[email protected]> wrote: >> A couple of related updates to base64 attached. > > Nice work. The two base64 patches look fine; I note that > they'll be applied in the opposite order. It felt a little odd > that the log in the bug-fix patch makes a point of saying > it's preserving backwards compatibility, yet the one listed > first goes ahead and breaks that.
Sorry, I should have specified order. Yes the backwards compat messages are awkward. I'll adjust the first change to say that "a following commit will further improve verification of numbers with leading zeros by dropping backwards compatibility wrt auto parsing oct and hex numbers." > I skimmed the larger base32-adding patch and found no nit to pick. thanks for the review! Pádraig
