On Fri, Sep 4, 2015 at 6:43 AM, Pádraig Brady <[email protected]> wrote: > On 09/09/14 10:50, Pádraig Brady wrote: >> On 09/09/2014 04:55 AM, Paul Eggert wrote: >>> I noticed other problems that are at least somewhat related to the >>> recent coreutils multi-binary executable changes, and fixed some of >>> these problems with the attached patches. >>> >>> Subject: [PATCH 3/4] maint: prefer 'return status;' to 'exit (status);' in >>> 'main' >>> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.23-19-g8defcee >> >> simpler so +1 >> There were a couple of syntax-check errors with this, fixed in >> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.23-21-g20f46a2 > > Another caveat with using return() instead of exit() > is that valgrind will now report mem allocated in main() > as "definitely lost" as noted at http://stackoverflow.com/q/31622764/4421 > > That precludes using this to auto flag mem leaks: > valgrind --leak-check=full --error-exitcode=1 > --errors-for-leak-kinds=definite > > The attached patch explicitly free()s these allocations, in dev builds.
Looks fine. Nit in commit log: s/bnuilds/builds/ Thanks.
