On 21/09/15 00:47, Bernhard Voelker wrote: >>From 1335ab2713aab020564275c49fdb3e92bb9a207b Mon Sep 17 00:00:00 2001 > From: Bernhard Voelker <[email protected]> > Date: Mon, 21 Sep 2015 01:40:33 +0200 > Subject: [PATCH] maint: use adaptive approach for `ulimit -v` based tests > > When configured with either 'symlinks' or 'shebangs' as value for > the --enable-single-binary option, tests based on `ulimit -v` are > skipped. The reason is that the multicall 'coreutils' binary requires > much more memory due to shared libraries being loaded, and the size of > the 'date' binary (~290KiB) compared to the multicall binary (~5MiB), > of course. Finally, in the case of 'shebangs', the starting shell > requires more memory, too > > Instead of using hard-coded values for the memory limit, use an > adaptive approach: first determine the amount of memory for a similar, > yet more trivial command, and then do the real test run using that
s/command/invocation of the command/ I can't find any significant issues with the patch at all. In future for i18n significant `ulimit -v`, we might have gen_min_ulimit_v_() do additional checking of setlocale() output with non "C" locales (I notice locale(1) doesn't set the exit value appropriately upon failure :/), and use that as additional space to add on top of the current adaptive method? thanks! Pádraig
