On 01/18/2016 02:27 PM, Pádraig Brady wrote:
On 18/01/16 18:18, Assaf Gordon wrote:
    FAIL: tests/cp/preserve-slink-time

-2016-01-18 12:21:28.294123000 -0500
+2016-01-18 12:21:28.296528000 -0500

cp -Pp didn't seem to preserve the timestamp on GPFS.
I'd need access to the system to see why.
I'd test with touch -d '...' to see if the timestamp was honored


Seems to be working when I try it manually:
===
  $ ln -s nosuch dangle
  $ ./src/stat --format=%y dangle
  2016-01-18 15:12:19.978310000 -0500
  $ ./src/cp -Pp dangle foo
  $ ./src/stat --format=%y dangle foo
  2016-01-18 15:12:19.978310000 -0500
  2016-01-18 15:12:19.978310000 -0500
===
   $ rm -f a b
   $ touch a ; sleep 1 ; ./src/cp -Pp a b
   $ stat --format=%y a b
   2016-01-18 14:56:22.068737000 -0500
   2016-01-18 14:56:22.068737000 -0500
===
   $ strace ./src/touch -d '2013-12-11 10:09:08.777777' d
   ...
   utimensat(0, NULL, [{1386774548, 777777000}, {1386774548, 777777000}], 0) = 0
   ...
   $ stat --format=%y d
   2013-12-11 10:09:08.777777000 -0500
===

So I added 'strace' to the "cp" execution inside the test, and also when used 
manually, they seem similar (both attached).

I can check more things if you have suggestions.

regards,
 - assaf


execve("./src/cp", ["./src/cp", "-Pp", "dangle", "foobar"], [/* 34 vars */]) = 0
brk(NULL)                               = 0x202b000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f052e408000
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=90585, ...}) = 0
mmap(NULL, 90585, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f052e3f1000
close(3)                                = 0
open("/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\34\2\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=2107760, ...}) = 0
mmap(NULL, 3932736, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f052de27000
mprotect(0x7f052dfdd000, 2097152, PROT_NONE) = 0
mmap(0x7f052e1dd000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1b6000) = 0x7f052e1dd000
mmap(0x7f052e1e3000, 16960, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f052e1e3000
close(3)                                = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f052e3f0000
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f052e3ee000
arch_prctl(ARCH_SET_FS, 0x7f052e3ee740) = 0
mprotect(0x7f052e1dd000, 16384, PROT_READ) = 0
mprotect(0x61a000, 4096, PROT_READ)     = 0
mprotect(0x7f052e409000, 4096, PROT_READ) = 0
munmap(0x7f052e3f1000, 90585)           = 0
brk(NULL)                               = 0x202b000
brk(0x204c000)                          = 0x204c000
brk(NULL)                               = 0x204c000
open("/usr/lib/locale/locale-archive", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=106065056, ...}) = 0
mmap(NULL, 106065056, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f0527900000
close(3)                                = 0
geteuid()                               = 10346
stat("foobar", 0x7fff53211500)          = -1 ENOENT (No such file or directory)
lstat("dangle", {st_mode=S_IFLNK|0777, st_size=12, ...}) = 0
lstat("foobar", 0x7fff53211290)         = -1 ENOENT (No such file or directory)
readlink("dangle", "no-such-file", 13)  = 12
symlink("no-such-file", "foobar")       = 0
lchown("foobar", 10346, 10273)          = 0
utimensat(AT_FDCWD, "foobar", [{1453148613, 394634717}, {1453148601, 908454000}], AT_SYMLINK_NOFOLLOW) = 0
lseek(0, 0, SEEK_CUR)                   = -1 ESPIPE (Illegal seek)
close(0)                                = 0
close(1)                                = 0
close(2)                                = 0
exit_group(0)                           = ?
+++ exited with 0 +++
execve("/gpfs/commons/home/agordon/projects/coreutils-8.24.163-3f02d/./src/cp", ["cp", "-Pp", "dangle", "d2"], [/* 77 vars */]) = 0
brk(NULL)                               = 0x1d04000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f0930cc3000
access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=90585, ...}) = 0
mmap(NULL, 90585, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f0930cac000
close(3)                                = 0
open("/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\34\2\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=2107760, ...}) = 0
mmap(NULL, 3932736, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f09306e2000
mprotect(0x7f0930898000, 2097152, PROT_NONE) = 0
mmap(0x7f0930a98000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1b6000) = 0x7f0930a98000
mmap(0x7f0930a9e000, 16960, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f0930a9e000
close(3)                                = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f0930cab000
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f0930ca9000
arch_prctl(ARCH_SET_FS, 0x7f0930ca9740) = 0
mprotect(0x7f0930a98000, 16384, PROT_READ) = 0
mprotect(0x61a000, 4096, PROT_READ)     = 0
mprotect(0x7f0930cc4000, 4096, PROT_READ) = 0
munmap(0x7f0930cac000, 90585)           = 0
brk(NULL)                               = 0x1d04000
brk(0x1d25000)                          = 0x1d25000
brk(NULL)                               = 0x1d25000
geteuid()                               = 10346
stat("d2", 0x7fff3f8852b0)              = -1 ENOENT (No such file or directory)
lstat("dangle", {st_mode=S_IFLNK|0777, st_size=7, ...}) = 0
lstat("d2", 0x7fff3f885040)             = -1 ENOENT (No such file or directory)
readlink("dangle", "no-such", 8)        = 7
symlink("no-such", "d2")                = 0
lchown("d2", 10346, 10273)              = 0
utimensat(AT_FDCWD, "d2", [{1453148568, 220293000}, {1453148568, 220313000}], AT_SYMLINK_NOFOLLOW) = 0
lseek(0, 0, SEEK_CUR)                   = -1 ESPIPE (Illegal seek)
close(0)                                = 0
close(1)                                = 0
close(2)                                = 0
exit_group(0)                           = ?
+++ exited with 0 +++

Reply via email to