This it looking great thanks.
Your examples look like a great set of tests.
Couple of nits in my very quick scan:

On 04/02/16 20:28, Assaf Gordon wrote:
> == TZ=America/Belize date --debug -u -d "TZ="Asia/Tokyo" 09:30:21 " ==
> 
> date: parsed time part: 09:30:21 
> date: input timezone: +09:00 (set from TZ='Asia/Tokyo' in date string)

Better to use TZ="..." as single quotes are not supported in that context

> date: using specified time as starting value: '09:30:21'
> date: using current date as starting value: '(Y-M-D) 2016-02-05'
> date: starting date/time: '(Y-M-D) 2016-02-05 09:30:21 TZ=+09:00'
> date: '(Y-M-D) 2016-02-05 09:30:21 TZ=+09:00' = 1454632221 epoch-seconds
> date: output timezone: +00:00 (set from TZ=UTC0 envionment value or --utc)

s/vio/viro/

> date: final epoch-seconds: 1454632221.000000000
> date: final date: '(Y-M-D) 2016-02-05 00:30:21' (UTC0)
> date: final date: '(Y-M-D) 2016-02-05 00:30:21' (Output timezone TZ=+00:00)
> Fri Feb  5 00:30:21 UTC 2016

BTW the repeated "date: " strings look a little redundant/non generic.
Perhaps they could be replaced with just ": " or something.

Also none of these new strings are marked for translation
(the module would then have to depend on gettext-h)

thanks!
Pádraig

Reply via email to