On Tue, Apr 5, 2016 at 2:12 AM, Bernhard Voelker <[email protected]> wrote: > On 04/04/2016 02:20 PM, Pádraig Brady wrote: >> * src/yes.c (main): For large inputs only write a single >> diagnostic for write errors. >> * tests/misc/yes.sh: Test when /dev/full is available. > > Nice catch! > > The patch per se LGTM ... but while at it, you may want to fix this > in tests/misc/yes.sh (right before your addition): > > > + external true 1 2 3 4 5 6[...] 3998 3999 4000 > ./tests/misc/yes.sh: line 35: external: command not found > > Introduced in v8.24-82-gf720844.
IMHO, it's better to put back the "env" and simply eliminate the "external=env" and "$external" uses, since "external" is almost a misnomer, when used in this context. What it intends to say is "non-built-in", whereas "external" could be interpreted as "not from coreutils", which is not the intent at all. Just think of using the "env " prefix as an idiom that is finally becoming more well known.
