On 04/06/2016 11:09 AM, [email protected] wrote: > From: Mattias Andrée <[email protected]> > > --- > doc/coreutils.texi | 7 ++++++- > src/test.c | 44 +++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 49 insertions(+), 2 deletions(-)
Thanks for the patch, and remembering to document it. However, it also needs a NEWS entry and testsuite coverage; by the time you do that, the patch may be non-trivial enough to need copyright assignment. Also, the bar for adding new options to 'test' is very high - is there any other existing practice (say in bash, ksh, zsh, BSD, or elsewhere) that is already using -E, and if so, are they using it for the same purpose? If so, mention it and this patch is worthwhile; if not, I'm a bit reluctant to be the first inventor, especially if something else more portable can be used. On the other hand, I readily concur that "test -s directory" does NOT accurately report whether the directory has contents, so maybe adding the new operator has justification on that grounds; it would also be nice if you could simultaneously propose it on the bash mailing list, so that multiple GNU programs implement the same semantics at once. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
