On 07/25/2016 01:16 PM, Philipp Thomas wrote:
> Hi Bernie,
> 
> * Bernhard Voelker ([email protected]) [20160724 23:33]:
> 
>> Maybe adding an IF_LINT'ed hash_free call would be worth;
>> otherwise it looks good to me.
> 
> I don't quite understand as filter_mount_list already does call hash_free at
> the end. So please explain.

hash_free is only called if (! devices_only), i.e., so not if the -a option
is passed.  There are also other allocations not free()d in df.c.  Maybe it'd
be good to guard them all with IF_LINT(...) for better maintainability: to
see what are real leaks and what is freed at exit anyway.

Have a nice day,
Berny

Reply via email to