Hello Pádraig and all,
On 10/31/2016 03:52 PM, Pádraig Brady wrote:
Patch above updated.
Also I improved the test a bit.
Thanks for the quick fix. I was able to check it on few system. Seems like
non-gnu systems have some issues.
All errors except Mac OS X (last in the list below) seems due to the same cause
(header related issue).
The Mac OS X error perhaps relates to a recent gnulib change (not sure).
regards,
- assaf
====
On AIX:
CC src/src_b2sum-md5sum.o
CC src/blake2/src_b2sum-blake2b-ref.o
CC src/blake2/src_b2sum-blake2s-ref.o
CC src/blake2/src_b2sum-blake2bp-ref.o
In file included from ./lib/stdlib.h:96:0,
from src/blake2/blake2bp-ref.c:17:
./lib/unistd.h:135:3: error: #error "Please include config.h first."
#error "Please include config.h first."
^
In file included from src/blake2/blake2bp-ref.c:16:0:
./lib/unistd.h:567:1: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'extern'
_GL_CXXALIAS_SYS (chdir, int, (const char *file) _GL_ARG_NONNULL ((1)));
^
./lib/stdlib.h:492:1: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'extern'
_GL_FUNCDECL_RPL (calloc, void *, (size_t nmemb, size_t size));
^
make: 1254-004 The error code from the last command is 1.
On OpenSolaris ( 5.10 and 5.10, sparc and i86 ):
CC src/src_b2sum-md5sum.o
CC src/blake2/src_b2sum-blake2b-ref.o
CC src/blake2/src_b2sum-blake2s-ref.o
CC src/blake2/src_b2sum-blake2bp-ref.o
In file included from ./lib/stdlib.h:96:0,
from src/blake2/blake2bp-ref.c:17:
./lib/unistd.h:135:3: error: #error "Please include config.h first."
#error "Please include config.h first."
^
In file included from /usr/include/sys/time.h:473:0,
from ./lib/sys/time.h:39,
from /usr/include/sys/select.h:28,
from ./lib/sys/select.h:36,
from /usr/include/sys/types.h:637,
from ./lib/sys/types.h:28,
from ./lib/stdio.h:58,
from src/blake2/blake2bp-ref.c:16:
./lib/unistd.h:567:1: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'extern'
_GL_CXXALIAS_SYS (chdir, int, (const char *file) _GL_ARG_NONNULL ((1)));
^
./lib/stdlib.h:495:1: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'extern'
_GL_CXXALIAS_SYS (calloc, void *, (size_t nmemb, size_t size));
^
make[2]: *** [src/blake2/src_b2sum-blake2bp-ref.o] Error 1
make[2]: Leaving directory
`/home/agn/pretest.2016-10-31.XoaGwj/coreutils-8.25.83-e49f5.kQAOkN/coreutils-8.25.83-e49f5'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/home/agn/pretest.2016-10-31.XoaGwj/coreutils-8.25.83-e49f5.kQAOkN/coreutils-8.25.83-e49f5'
make: *** [all] Error 2
OpenBSD 6.0:
CC src/blake2/src_b2sum-blake2s-ref.o
CC src/blake2/src_b2sum-blake2bp-ref.o
In file included from ./lib/stdlib.h:96,
from src/blake2/blake2bp-ref.c:17:
./lib/unistd.h:135:3: error: #error "Please include config.h first."
In file included from ./lib/stdlib.h:96,
from src/blake2/blake2bp-ref.c:17:
./lib/unistd.h:567: error: expected '=', ',', ';', 'asm' or '__attribute__'
before 'extern'
In file included from src/blake2/blake2bp-ref.c:17:
./lib/stdlib.h:495: error: expected '=', ',', ';', 'asm' or '__attribute__'
before 'extern'
*** Error 1 in . (Makefile:11157 'src/blake2/src_b2sum-blake2bp-ref.o': @echo "
CC " src/blake2/src_b2sum-blake2bp-ref.o;gcc -std=gnu9...)
*** Error 1 in . (Makefile:11660 'all-recursive')
*** Error 1 in /tmp/coreutils-8.25.83-e49f5.iCEeCv/coreutils-8.25.83-e49f5
(Makefile:5912 'all')
FreeBSD 11-p1:
CC src/blake2/src_b2sum-blake2s-ref.o
CC src/blake2/src_b2sum-blake2bp-ref.o
In file included from src/blake2/blake2bp-ref.c:17:
In file included from ./lib/stdlib.h:96:
./lib/unistd.h:135:3: error: "Please include config.h first."
#error "Please include config.h first."
^
./lib/unistd.h:137:1: error: unknown type name '_GL_INLINE_HEADER_BEGIN'
_GL_INLINE_HEADER_BEGIN
^
./lib/unistd.h:567:1: error: expected identifier or '('
_GL_CXXALIAS_SYS (chdir, int, (const char *file) _GL_ARG_NONNULL ((1)));
^
./lib/time.h:199:5: note: expanded from macro '_GL_CXXALIAS_SYS'
_GL_EXTERN_C int _gl_cxxalias_dummy
^
./lib/time.h:114:23: note: expanded from macro '_GL_EXTERN_C'
# define _GL_EXTERN_C extern
^
In file included from src/blake2/blake2bp-ref.c:17:
In file included from ./lib/stdlib.h:96:
./lib/unistd.h:1894:1: error: unknown type name '_GL_INLINE_HEADER_END'
_GL_INLINE_HEADER_END
^
In file included from src/blake2/blake2bp-ref.c:17:
./lib/stdlib.h:492:1: error: expected identifier or '('
_GL_FUNCDECL_RPL (calloc, void *, (size_t nmemb, size_t size));
^
./lib/time.h:125:3: note: expanded from macro '_GL_FUNCDECL_RPL'
_GL_FUNCDECL_RPL_1 (rpl_##func, rettype, parameters_and_attributes)
^
./lib/time.h:127:3: note: expanded from macro '_GL_FUNCDECL_RPL_1'
_GL_EXTERN_C rettype rpl_func parameters_and_attributes
^
./lib/time.h:114:23: note: expanded from macro '_GL_EXTERN_C'
# define _GL_EXTERN_C extern
^
5 errors generated.
*** Error code 1
Stop.
make[2]: stopped in
/tmp/coreutils-8.25.83-e49f5.XXXXXX.eaBcUPIg/coreutils-8.25.83-e49f5
*** Error code 1
===
On Mac OS X (tested on 4 different Darwin versions with different Xcode
versions)
all have the same error.
I'm not sure it relates to blake2, perhaps this is a carry-over from a gnulib
change):
CC lib/linebuffer.o
CC lib/localcharset.o
CC lib/glthread/lock.o
In file included from lib/glthread/lock.c:23:
In file included from ./lib/glthread/lock.h:90:
In file included from ./lib/pthread.h:50:
./lib/sched.h:27:6: error: invalid token at start of a preprocessor
expression
# if @HAVE_SYS_CDEFS_H@
^
1 error generated.
make[2]: *** [lib/glthread/lock.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
