On 31/01/17 22:03, Jim Meyering wrote:
> Nice work, eliminating another test race condition.
> 
> On Tue, Jan 31, 2017 at 9:41 PM, Pádraig Brady <[email protected]> wrote:
>> +grep -F 'become accessible' out  ||                      # usual case
>> +grep -F 'has appeared' out       || { fail=1; cat out; } # with slow rmdir
> 
> I would find that more readable with a single grep with -E+| for
> alternation, instead of two invocations and "||"?
> 
>   # The first is the common case, "has appeared" arises with slow rmdir.
>   grep -E 'become accessible|has appeared' out || { fail=1; cat out; }
> 
agreed. thanks

Reply via email to