On 03/08/2017 02:49 AM, Pádraig Brady wrote:
> This dependency looks superflous because:
> - It's not checking an install time issue so is only useful for devs really
> - tr works fine on solaris and freebsd at least
> - Our tr will probably be built anyway (and used in the single binary case)
> - even if tr doesn't work as expected, uniq will absorb the error
Thanks for the explanation. Patch attached.
> Pleas push.
I'm not 100% happy with the wording in the commit message,
so feel free to { review || adjust } && push.
Thanks & have a nice day,
Berny
>From ddd06685cb37167d599632a1c1192c9a4874fe16 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <[email protected]>
Date: Wed, 8 Mar 2017 08:27:46 +0100
Subject: [PATCH] build: remove dependency between check-duplicate-no-install
and tr
* src/local.mk (check-duplicate-no-install): Remove src/tr as
dependency; otherwise, src/tr was built unnecessarily after
'make check' for single-binary builds.
Discussed in:
http://lists.gnu.org/archive/html/coreutils/2017-03/msg00015.html
---
src/local.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/local.mk b/src/local.mk
index 84df099..9b2b172 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -644,7 +644,7 @@ check-README:
# entry, because if that were to happen, it *would* be installed
# by default.
.PHONY: check-duplicate-no-install
-check-duplicate-no-install: src/tr
+check-duplicate-no-install:
$(AM_V_GEN)test -z "`echo '$(EXTRA_PROGRAMS)' | tr ' ' '\n' | uniq -d`"
# Use the just-built 'ginstall', when not cross-compiling.
--
2.1.4
