Hi,
just a nit, there is a typo in an error message...
On Wed, Apr 26, 2017 at 03:57:12PM +0200, Sebastian Kisela wrote:
> [...]
> diff --git a/src/runcon.c b/src/runcon.c
> index 92f519d..9021614 100644
> --- a/src/runcon.c
> +++ b/src/runcon.c
> [...]
> @@ -157,7 +170,15 @@ main (int argc, char **argv)
> case 'c':
> compute_trans = true;
> break;
> -
> + case NO_NEW_PRIVS_ARG:
> +#ifdef PR_SET_NO_NEW_PRIVS
> + no_new_privs = true;
> + break;
> +#else
> + die (EXIT_FAILURE, 0,
> + _("--no-new-privs cannot be used in the cureutils version,\
> + that is currently installed."));
s/cure/core/
I am not sure how whitespace is handled inside _(). How many spaces are
shown in the output after the comma? Zero, one, or many?
A better wording for the error message might be:
"--no-new-privs support is missing from the currently installed runcon binary."
Thanks,
Erik
--
I think of math as a splendid way to learn to think straight.
-- Bjarne Stroustrup
