On 02/02/2018 09:27 PM, Daniel Gall wrote: > Sorry for the delay; life intervened. In addition to the feature add, > I found a place where du was calling xcalloc and did not check that > the returned pointer was not NULL. I added a check.
Wrong; the contract of xcalloc() is that it CAN'T return NULL (it will have abort()ed instead, if you are low on memory). >>From 544c581654cd0dcfb363215801245a7c2dd3fcd3 Mon Sep 17 00:00:00 2001 > From: Daniel Gall <[email protected]> > Date: Fri, 2 Feb 2018 17:18:44 -0500 > Subject: [PATCH] added du group reporting feature and fixed a bug where du > allocated memory and did not check that the target pointer was not NULL after > the allocation call. Too long of a subject line; the best commits include a one-line summary (~60 characters or less), then a blank line, then more details. > +++ b/NEWS > @@ -32,6 +32,8 @@ GNU coreutils NEWS > -*- outline -*- > df no longer hangs when given a fifo argument. > [bug introduced in coreutils-7.3] > > + du no longer allocates memory without checking whether the > allocation call succeeded. This change is not needed, as it was not a bug in the first place. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
