On 04/27/2018 01:31 AM, Bernhard Voelker wrote: > On 04/26/2018 09:17 AM, Assaf Gordon wrote: >> Attached an updated patch, hopefully addressing all the issues below. > > Great work, thanks! > > One nit: env -v shows a confusing error diagnostic when it is > separated from the -S option on the shebang line:
> > Well, env doesn't know at that point that -S is coming later ... still > the error message is really confusing. Any idea? We could include ' ' (and maybe '\t') as part of the short-option optstring accepted in getopt_long(), as an undocumented silent no-op. That would make '-v ' behave the same as '-v'. But I'm not sure if it is ever possible to coax getopt_long() into parsing '-v-' as accepting a short option named '-' (since usually, the string '--' is treated as end-of-options). Worth a try, to see if it works? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
