Re: new snapshot available: coreutils-8.29.57-2ed7c2.tar.xz

Assaf Gordon Tue, 26 Jun 2018 04:16:24 -0700

Hello Pádraig and all,

First,
thanks for all the hard work regarding the env-S test failure.

The shebang length limit is an interesting edge-case I haven't thought about...



Second,
Attached few test failures (not env-S-script/shebang ones).

======

On Debian 8.10/i686 (this is gcc45.fsffrance.org from gcc copmile farm):

  FAIL: tests/cp/fiemap-perf

This is a false-positive due to the test assuming that
copying 1TB of sparse file will finish in less than 10 seconds:
https://opengrok.housegordon.com/source/xref/coreutils/tests/cp/fiemap-perf.sh#42

Was previously reported for 8.29:
https://lists.gnu.org/archive/html/coreutils/2017-12/msg00059.html

A bit more information this time:

  $ timeout 10 truncate -s1T f
  $ ls -lh f*
  -rw-r--r-- 1 agn agn 1.0T Jun 26 12:01 f

$ timeout 10 cp f f2 ; echo $?

strace shows that the 'ioctl(FS_IOC_FIEMAP)' did not terminate within 10 seconds. Perhaps it's a slow machine - gcc45 is "AMD Athlon(tm) II X4 640 Processor".


=====

On Debian 9.4/x86_64:

   FAIL: tests/df/df-symlink

This is a false-positive, on my system /tmp is bind-mounted to /scratch
(which is mounted from /dev/sdb2):

  ++ grep -F /dev/sdb2
  ++ wc -l
  + test 1 = 1
  + df --out=source,target .
  + compare exp out
  + compare_dev_null_ exp out
  + test 2 = 2
  + test xexp = x/dev/null
  + test xout = x/dev/null
  + return 2
  + case $? in
  + compare_ exp out
  + diff -u exp out
  --- exp 2018-06-25 05:16:53.034770806 -0600
  +++ out 2018-06-25 05:16:53.042771018 -0600
  @@ -1,2 +1,2 @@
   Filesystem     Mounted on
  -/dev/sdb2      /tmp
  +/dev/sdb2      /scratch
  + fail=1

=====

On OpenBSD 6.2/amd64, few test failures:

FAIL: tests/misc/env

seems like "env -" does not work. I will investigate further

(perhaps I've broken something with the changes to the command-line processing?).


  $ ./src/env --version
  env (GNU coreutils) 8.29.57-2ed7c2
  Copyright (C) 2018 Free Software Foundation, Inc.

License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses /gpl.html>.

  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.

  Written by Richard Mlynarik, David MacKenzie, and Assaf Gordon.

  $ ./src/env -
  env: invalid option -- '-'
  Try './src/env --help' for more information.


FAIL: tests/misc/env-S

fails for the same reason:

env-S.pl: test err_sp1: stderr mismatch, comparing err_sp1.1 (expected) and err_sp1.E (actual)

  *** err_sp1.1   Mon Jun 25 04:41:28 2018
  --- err_sp1.E   Mon Jun 25 04:41:28 2018
  ***************
  *** 1,2 ****
  ! env: invalid option -- '-'
    Try 'env --help' for more information.
  --- 1,2 ----
  ! env: unknown option -- S cat -n
    Try 'env --help' for more information.


   FAIL: tests/misc/env-S

fails like other systems.


Also one ERROR:

  ERROR: tests/misc/usage_vs_getopt
  =================================

  using SHELL=/bin/sh with 'set -x' corrupts stderr
  chroot: unknown option -- thisoptiondoesnotexist
  usage_vs_getopt.sh: set-up failure:
  ERROR tests/misc/usage_vs_getopt.sh (exit status: 99)

I believe this is a false-positive.
The "framework_failure_" is triggered
when testing an invalid short option on line 37:
https://opengrok.housegordon.com/source/xref/coreutils/tests/misc/usage_vs_getopt.sh#37

Programs are tested like so:

     chroot -/

Then "grep" searches for "'/'" in STDERR (i.e. single-quote,slash-single-quote).


On this system (OpenBSD 6.2 with C locale), the error message does
not contain single-quotes and the 'grep' fails.
This happens in all programs:

  $ ./src/env --version | head -n1
  env (GNU coreutils) 8.29.57-2ed7c2
  $ ./src/env -/
  env: unknown option -- /
  Try './src/env --help' for more information.

  $ ./src/chroot --version | head -n1
  chroot (GNU coreutils) 8.29.57-2ed7c2
  $ ./src/chroot -/
  chroot: unknown option -- /
  Try './src/chroot --help' for more information.

Attached is a possible patch to avoid the failure.

Interesting, just below the modified "grep" in "usage_vs_getopt.sh"
there's a "sed" invocate that also searches for the pattern (line 40 ,

https://opengrok.housegordon.com/source/xref/coreutils/tests/misc/usage_vs_getopt.sh#40 ). I did not modify it, and the tests still pass - I don't think it is actually used (the "pat" file isn't checked).


======

More tests to follow soon.

regards,
 - assaf

==========================================================
   GNU coreutils 8.29.57-2ed7c2: ./tests/test-suite.log
==========================================================

# TOTAL: 608
# PASS:  482
# SKIP:  124
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

FAIL: tests/misc/env-S-script
=============================

[[ details omitted by assaf ]]



FAIL: tests/cp/fiemap-perf
==========================

++ initial_cwd_=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2
+++ testdir_prefix_
+++ printf gt
++ pfx_=gt
+++ mktempd_ /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2 gt-fiemap-perf.sh.XXXX
+++ case $# in
+++ destdir_=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2
+++ template_=gt-fiemap-perf.sh.XXXX
+++ MAX_TRIES_=4
+++ case $destdir_ in
+++ destdir_slash_=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/
+++ case $template_ in
++++ unset TMPDIR
+++ d=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
+++ case $d in
+++ :
+++ test -d /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
++++ ls -dgo /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
+++ perms='drwx------ 2 4096 Jun 25 12:42 /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI'
+++ case $perms in
+++ :
+++ echo /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
+++ return
++ test_dir_=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
++ cd /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
++ gl_init_sh_nl_='
'
++ IFS=' 	
'
++ for sig_ in 1 2 3 13 15
+++ expr 1 + 128
++ eval 'trap '\''Exit 129'\'' 1'
+++ trap 'Exit 129' 1
++ for sig_ in 1 2 3 13 15
+++ expr 2 + 128
++ eval 'trap '\''Exit 130'\'' 2'
+++ trap 'Exit 130' 2
++ for sig_ in 1 2 3 13 15
+++ expr 3 + 128
++ eval 'trap '\''Exit 131'\'' 3'
+++ trap 'Exit 131' 3
++ for sig_ in 1 2 3 13 15
+++ expr 13 + 128
++ eval 'trap '\''Exit 141'\'' 13'
+++ trap 'Exit 141' 13
++ for sig_ in 1 2 3 13 15
+++ expr 15 + 128
++ eval 'trap '\''Exit 143'\'' 15'
+++ trap 'Exit 143' 15
++ trap remove_tmp_ 0
+ path_prepend_ ./src
+ test 1 '!=' 0
+ path_dir_=./src
+ case $path_dir_ in
+ abs_path_dir_=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/./src
+ case $abs_path_dir_ in
+ PATH=/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/./src:/home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/src:/usr/local/bin:/usr/bin:/bin:/usr/games:/sbin:/usr/sbin
+ create_exe_shims_ /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/./src
+ case $EXEEXT in
+ return 0
+ shift
+ test 0 '!=' 0
+ export PATH
+ print_ver_ cp
+ require_built_ cp
+ skip_=no
+ for i in '"$@"'
+ case " $built_programs " in
+ test no = yes
+ test yes = yes
+ local i
+ for i in '$*'
+ env cp --version
cp (GNU coreutils) 8.29.57-2ed7c2
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Torbjorn Granlund, David MacKenzie, and Jim Meyering.
+ touch fiemap_chk
+ fiemap_capable_ fiemap_chk
+ python
+ python /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/tests/fiemap-capable fiemap_chk
+ df -t ext2 -t ext3 .
df: no file systems processed
+ timeout 10 truncate -s1T f
+ filefrag f
f: 0 extents found
+ filefrag f
+ grep -F ': 0 extents found'
+ timeout 10 cp f f2
+ fail=1
++ stat --printf %s f
++ stat --printf %s f2
+ test 1099511627776 = 0
+ fail=1
+ Exit 1
+ set +e
+ exit 1
+ exit 1
+ remove_tmp_
+ __st=1
+ cleanup_
+ :
+ test '' = yes
+ cd /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2
+ chmod -R u+rwx /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
+ rm -rf /home/agn/pretest.2018-06-25.v8QEFW/coreutils-8.29.57-2ed7c2.r7HTwM/coreutils-8.29.57-2ed7c2/gt-fiemap-perf.sh.EJZI
+ exit 1
FAIL tests/cp/fiemap-perf.sh (exit status: 1)

Debian_8.10_i686--fiemap-strace.log.gz
Description: application/gzip

Debian_9.4_x86_64CCclang-3.8--tests-suite-summary.log.gz
Description: application/gzip

OpenBSD_6.2_amd64--tests-suite-summary.log.gz
Description: application/gzip

>From c5daae5ae3cca0cebd72a3ee57ecfe6bf63d8b83 Mon Sep 17 00:00:00 2001
From: Assaf Gordon <[email protected]>
Date: Tue, 26 Jun 2018 05:04:45 -0600
Subject: [PATCH] tests: accept getopt errors without single-quotes

On OpenBSD 6.2, invalid single options produce error messages
without single quotes:

    $ ./src/chroot -/
    chroot: unknown option -- /

As opposed to other systems:

    ./src/chroot: invalid option -- '/'

Modify the grep search to accept this.

* tests/misc/usage_vs_getopt.sh (checkprg): Change the grep pattern
to accomodate no-single-quotes cases.
---
 tests/misc/usage_vs_getopt.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/misc/usage_vs_getopt.sh b/tests/misc/usage_vs_getopt.sh
index aec1c6da2..c20e15ada 100755
--- a/tests/misc/usage_vs_getopt.sh
+++ b/tests/misc/usage_vs_getopt.sh
@@ -36,7 +36,7 @@ checkprg () {
 
   # Append the pattern for a short unknown option.
   returns_ $rcexp $prg -/ >/dev/null 2> err || fail=1
-  grep -F "'/'" err || framework_failure_
+  grep " '*/'*\$" err || framework_failure_
   sed -n "1s/'\/'/'OPT'/p" < err >> pat || framework_failure_
 
   # Get output for --help.
-- 
2.11.0

Re: new snapshot available: coreutils-8.29.57-2ed7c2.tar.xz

Reply via email to