On Sat, Jun 30, 2018 at 6:55 PM, Pádraig Brady <[email protected]> wrote: > * tests/cp/fiemap-FMR.sh: Ensure perl is parameterized to $PERL, > and ensure require_perl_ is used, so tests are skipped appropriately. > * tests/cp/preserve-gid.sh: Likewise. > * tests/du/long-from-unreadable.sh: Likewise. > * tests/misc/env-S-script.sh: Likewise. > * tests/misc/sort-benchmark-random.sh: Likewise. > * tests/rm/deep-2.sh: Likewise. ... > -perl -e ' > +$PERL -e ' ... > -perl -e ' > +$PERL -e ' ... > -: ${PERL=perl} > $PERL \ > -e 'my $d = "x" x 200; foreach my $i (1..52)' \ > -e ' { mkdir ($d, 0700) && chdir $d or die "$!" }' \
Thanks for all the clean-up. That looks fine. For a further (separate) diff, what do you think about also defining a "perl" function? Then, the majority of those invocations would have the more natural "perl -e ..." look.
