On 07/21/2018 10:36 PM, Pádraig Brady wrote: > On 19/07/18 10:22, Bernhard Voelker wrote: >> On 06/25/2018 06:48 PM, Pádraig Brady wrote: >>> `make gnulib-sync` would definitely be worth doing. >> >> Done in the attached. WDYT? > > I like it. It works well here.
Minor nit (to my own patch): >> Subject: [PATCH] maint: provide make target to update gnulib to latest >> >> * Makefile.am (gnulib-sync, update-gnulib-to-latest): Add target to >> pull the latest commit of the gnulib submodule, and also to copy over >> the files we keep in sync; add them to the index as well. ______________________________^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ The code doesn't do that. As one has to do the commit manually later on anyway, I suggest to remove that sentence from the commit message (instead of adding 'git add ...' to the 'gnulib-sync' target). Okay? Thanks & have a nice day, Berny
