Pádraig Brady <[email protected]> writes: > On 04/03/2020 14:46, Pádraig Brady wrote: >> On 04/03/2020 13:44, Marius Bakke wrote: >>> Pádraig Brady <[email protected]> writes: >> >>>> I don't see /bin/env being used here. >>> >>> Really? Can you send a trace of 'make check TESTS=tests/misc/env-S.pl'? >>> Curious how it is supposed to work... >> >> Oops I typod my grep. I do see the /usr/bin/env now. >> The reason is, where we run env with -i the PATH is cleared, >> and the system then falls back to default paths: >> >> $ strace -e execve src/env -i A=B env >> execve("src/env", ["src/env", "-i", "A=B", "env"], 0x7ffcfede1638 /* 65 vars >> */) = 0 >> execve("/usr/bin/env", ["env"], 0x1cfa380 /* 1 var */) = 0 >> A=B >> >> We could avoid that by specifying the path to our built env(1) instead. >> I'll look at doing something with $abs_top_builddir/src/env > > The attached should address this I think.
Thanks! It fixed most of the failing tests, but missed the first five: FAIL: tests/misc/env-S ====================== env (GNU coreutils) 8.31.99-f2034 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Richard Mlynarik, David MacKenzie, and Assaf Gordon. 1... env-S.pl: test 1 failed: exit status mismatch: expected 0, got 127 2... env-S.pl: test 2 failed: exit status mismatch: expected 0, got 127 3... env-S.pl: test 3 failed: exit status mismatch: expected 0, got 127 4... env-S.pl: test 4 failed: exit status mismatch: expected 0, got 127 5... env-S.pl: test 5 failed: exit status mismatch: expected 0, got 127 [...] env-S.pl: test 1-debug failed: exit status mismatch: expected 0, got 127 2-debug... env-S.pl: test 2-debug failed: exit status mismatch: expected 0, got 127 3-debug... env-S.pl: test 3-debug failed: exit status mismatch: expected 0, got 127 4-debug... env-S.pl: test 4-debug failed: exit status mismatch: expected 0, got 127 5-debug... env-S.pl: test 5-debug failed: exit status mismatch: expected 0, got 127 All other tests were OK.
signature.asc
Description: PGP signature
