Re: [PATCH] copy: exit immediately upon failure to allocate hash memory

[Bernhard Voelker]

On 5/3/21 7:57 PM, Pádraig Brady wrote:
> Addressed with the attached.

Minor nit:

  berny@blackice:~/coreutils> make sc_space_before_open_paren
  space_before_open_paren
      xalloc_die();
      xalloc_die();
  *** src/copy.c
  maint.mk: the above files lack a space-before-open-paren
  make: *** [cfg.mk:721: sc_space_before_open_paren] Error 1

Patch attached.

Have a nice day,
Berny

>From 65e4d0f71e3df711cf604209e148a051cd71580f Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <m...@bernhard-voelker.de>
Date: Thu, 6 May 2021 23:38:53 +0200
Subject: [PATCH] maint: fix sc_space_before_open_paren failure

* src/copy.c (dest_info_init): Add space before parens.
(src_info_init): Likewise.
Syntax-check failure introduced in the previous commit.
---
 src/copy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/copy.c b/src/copy.c
index af16bab69..9fb2420e1 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -1954,7 +1954,7 @@ dest_info_init (struct cp_options *x)
                        triple_compare,
                        triple_free);
   if (! x->dest_info)
-    xalloc_die();
+    xalloc_die ();
 }
 
 /* Initialize the hash table implementing a set of F_triple entries
@@ -1978,7 +1978,7 @@ src_info_init (struct cp_options *x)
                        triple_compare,
                        triple_free);
   if (! x->src_info)
-    xalloc_die();
+    xalloc_die ();
 }
 
 /* When effecting a move (e.g., for mv(1)), and given the name DST_NAME
-- 
2.31.1