On Monday, April 11, 2022 2:59:10 PM CEST Pádraig Brady wrote: > Your message was unintentionally dropped from the list. > Thanks for taking the extra time to mail this directly. > > Your analysis is correct, but setting LC_MESSAGES=C might not work in all > cases. We had issues previously with disparate LC_CTYPE and LC_MESSAGES on > macos as per: https://github.com/coreutils/coreutils/commit/04148c99c > So the attached adjusts things to only look for the problematic > character in the warning. > > cheers, > Pádraig
I hit the same issue when I tried to build coreutils-9.0.193-54bec for Fedora. The mentioned patch has fixed it for me. I was able to successfully build the package (and pass all tests) in Fedora and EPEL build roots: https://copr.fedorainfracloud.org/coprs/kdudka/coreutils-next/build/4174371/ I only had to revert the following upstream commit, which was unnecessarily conflicting with our i18n patch: https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v9.0-117-g423fed3dd84 Thanks! Kamil > -------- Forwarded Message -------- > Subject: [a...@offog.org: Re: new snapshot available: > coreutils-9.0.193-54bec.tar.xz] Date: Mon, 11 Apr 2022 03:17:15 +0100 > From: Adam Sampson <a...@offog.org> > To: p...@draigbrady.com > > Hi Pádraig, > > (Apologies if this is a duplicate - I sent it to the coreutils@ list but > it hasn't come through.) > > Pádraig Brady <p...@draigbrady.com> writes: > > cd coreutils-9.0.193-54bec/ > > ./configure && make check VERBOSE=yes > > I've just tried this and I get one failure in the new printf-mb test -- > the log is below. Since LC_ALL is set to fr_FR.UTF-8, the error messages > are printed in French, and the test script is expecting them to be in > English; should it set LC_MESSAGES=C like ls/dired.sh does? > > (This is on a custom GNU/Linux system with glibc 2.35 and coreutils 9.0 > installed.) > > Thanks, > Adam > > FAIL: tests/misc/printf-mb > ========================== > > > + diff -u exp_err err > --- exp_err 2022-04-09 17:10:01.144175356 +0100 > +++ err 2022-04-09 17:10:01.142175368 +0100 > @@ -1,2 +1,2 @@ > -printf: warning: ": character(s) following character constant have been > ignored -printf: warning: ': character(s) following character constant have > been ignored +printf: avertissement: " : caractères suivant la constante > caractère ont été ignorés +printf: avertissement: ' : caractères > suivant la constante caractère ont été ignorés + fail=1