On 15/01/2025 07:33, Bernhard Voelker wrote:
Hi Padraig,
On 1/15/25 02:36, Pádraig Brady wrote:
This avoids a test hang seen with bash on Solaris 11
+ # Wrap with timeout as on some systems (like Solaris 11)
+ # fork() can return EAGAIN under vm constraints,
+ # causing bash at least to loop retrying the fork
thanks, the reasoning becomes clear with this.
+ timeout 1 true >/dev/null ||
+ skip_ 'ulimit -v cannot be safely checked'
- ulimit -v $v && "$@"
- ) >/dev/null 2>&1
+ timeout 10 $SHELL "$abs_srcdir"/tests/ulimit_supported "$@"
ulimit_supported is mainly used by get_min_ulimit_v_ for a given
coreutils tool, while the above now uses $SHELL in between:
isnt't that usually much larger than our tools, and hence the
resulting minimum ulimit_v will be wrong then?
A valid consideration, but I think that should be OK
as the `ulimit -v` is only applied to the last subshell,
and so shouldn't behave significantly differently.
I.e. we're doing, timeout -> $SHELL -> ulimit; not
ulimit -> timeout -> $SHELL
cheers,
Pádraig
