On 18/05/2025 06:20, Collin Funk wrote:
Hi Pádraig,My last commit broke 'make distcheck' with the following: GEN lib/wctype.h GEN src/coreutils.h make[3]: *** No rule to make target 'src/make-prime-list.c', needed by 'src/primes.h'. Stop. make[3]: Leaving directory '/home/collin/.local/src/coreutils/tests/torture/coreutils/test/coreutils-9.7.25-3844c1' make[2]: *** [dist-check.mk:113: my-distcheck] Error 2 This was because I forgot to put src/make-prime-list.c in EXTRA_DIST so it was included in the tarball after removing it from noinst_PROGRAMS. The first patch fixes this. The second patch generates src/crctab.c at build time as you mentioned in the other thread. The code for generating src/crctab.c is very portable, but I still put the file in EXTRA_DIST so the tarball has the file and it doesn't need to be generated. Realistically it would only matter if you were using a cross-compiler on a machine without a host compiler, though. Collin
I adjusted comments slightly and pushed. thanks again! Pádraig
