Re: [PATCH] fix build on macos 12.6

[Pádraig Brady]

On 18/09/2025 18:16, Collin Funk wrote:

Pádraig Brady <p...@draigbrady.com> writes:

Note it works to explicitly link @INTL_MACOS_LIBS@ in coreutils with:

   diff --git a/src/local.mk b/src/local.mk
    LDADD = src/libver.a lib/libcoreutils.a $(LIBINTL) $(MBRTOWC_LIB) \
   -  lib/libcoreutils.a
   +  @INTL_MACOSX_LIBS@ lib/libcoreutils.a

I was unsure about that though as localename already
had the same @INTL_MACOSX_LIBS@ link requirements,
though I now see coreutils didn't actually use localename,
and now pulls localename-unsafe transitively through nstrftime.

I'll apply the attached to coreutils in a while.

I don't think it was a result of recent changes. Grisha Levit reported
it a bit ago, but I forgot to get around to checking if his patch was
correct [1].

[1] https://lists.gnu.org/archive/html/coreutils/2025-07/msg00047.html

Oh right.
I've already pushed (my simpler) change, sorry.
We can reconsider Grisha's patch if needed.

cheers,
Padraig