On 16/09/2025 23:04, Collin Funk wrote:
Pádraig Brady <[email protected]> writes:
Attached.
Text itself looks good.
Minor nit, though, shouldn't spaces in Texinfo files have two spaces
after periods to be consistent? Or do we not care about it?
I learned to type with 1 space after periods, so that is my preference
when typing. But using 2 consistently seems better than mixing the two
styles, in my opinion.
Oh right. I reformatted with gq in vim to rewrap etc. Fixed.
Also, curious about one thing mentioned in the patch:
+External library detection is automatic for OpenSSL, so you must use the
+@samp{--with-openssl=no} configure option to disable this if desired.
+Conversely, the Linux kernel cryptographic API is not used automatically and
+must be explicitly enabled with the @samp{--with-linux-crypto} configure
+option.
Why is --with-linux-crypto not used by default, and then turned off if a
system does not support AF_ALG? AFAIK they have optimized routines for
many architectures, but I have not benchmarked them against
OpenSSL. Maybe there is some history I am missing here?
Details here: https://github.com/coreutils/gnulib/commit/71cc633a
cheers,
Padraig
