Paul Eggert wrote: > I'm not a fan of 'abort' calls merely to pacify older, buggier > compilers.
Oh, I like abort() because when it is invoked, it produces a good message in the shell and a stack trace in the debugger. Unlike some gcc built-ins, that report a SIGILL (illegal instruction) in some cases (e.g. wrong use of va_arg). > That being said, a less-intrusive pacification change would > be fine. Does the attached patch work for you? Yes: It fixes the warnings on both FreeBSD 11 and OpenBSD 7.6. More importantly, the control flow is human-understandable. And it is simpler than my proposed patch. Thanks for the improvement! Bruno
