Re: [PATCH 2/2] pr: promptly diagnose write errors

[Pádraig Brady]

On 22/10/2025 18:54, Collin Funk wrote:

Pádraig Brady <p...@draigbrady.com> writes:

@@ -2546,6 +2549,9 @@ read_line (COLUMN *p)
          }

print_clump (p, chars, clump_buff);

+
+      if (ferror (stdout))
+        write_error ();
      }
  }

Perhaps this check should go into print_clump()? I think it makes more
sense to check for output errors there, instead of read_line() which is
primarily responsible for processing the input file.

The patch works regardless, though.

Good call.
I made that change and pushed all 4 patches.

thanks for the review!

Padraig