Pádraig Brady <[email protected]> writes: > On 06/01/2026 01:56, Collin Funk wrote: >> Collin Funk <[email protected]> writes: >> >>> +: > "$(bad_unicode)" || skip_ 'bad unicode not supported in file names' >> Oops, I forgot we can't do this. I applied the additional patch >> locally: >> diff --git a/tests/mktemp/bad-unicode.sh >> b/tests/mktemp/bad-unicode.sh >> index 2583a251a..ea67b5253 100755 >> --- a/tests/mktemp/bad-unicode.sh >> +++ b/tests/mktemp/bad-unicode.sh >> @@ -19,7 +19,7 @@ >> . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src >> print_ver_ mktemp >> -: > "$(bad_unicode)" || skip_ 'bad unicode not supported in file >> names' >> +echo a > "$(bad_unicode)" || skip_ 'bad unicode not supported in file names' > > Maybe s/file names/shell or file system/ > > You may prefer to use no `if` and reduce all the "fail=1" by doing: > > one && > two && > ... || fail=1
Good idea, I made those changes and pushed [1]. Also moved the other test out of tests/misc [2]. Thanks for the review. Collin [1] https://github.com/coreutils/coreutils/commit/1f1bce27d7e096c7bcf196e1af3b0b13472ac252 [2] https://github.com/coreutils/coreutils/commit/0fcdd37fbd78289ed3a1ed43231d619cee9b7eb1
