Pádraig Brady <[email protected]> writes:
> On 10/01/2026 05:22, Collin Funk wrote:
>> There isn't really a good case for the non --check case. If a system
>> has a small limit on the maximum number of arguments it will run too
>> quickly.
>>
> Nice one. I'd make two small tweaks,
>
> cheers,
> Padraig
>
> diff --git a/tests/misc/write-errors.sh b/tests/misc/write-errors.sh
> index 43397e4fa..3773dda39 100755
> --- a/tests/misc/write-errors.sh
> +++ b/tests/misc/write-errors.sh
> @@ -24,14 +24,14 @@ if ! test -w /dev/full || ! test -c /dev/full; then
> skip_ '/dev/full is required'
> fi
>
> -dev_null_hash=$(cksum -a sha3 -l 256 /dev/null)
> +dev_null_hash=$(cksum -a sha3 -l 256 /dev/null) || framework_failure_
Yep, makes sense. I didn't just write the checksum itself since it would
be longer than 80 characters in cause 'make syntax-check' to fail. If
this command fails you will likely have bigger problems to deal with, so
it felt better than using printf or something to fit line limits.
> # Writers that may output data indefinitely.
> # First word in command line is checked against built programs.
> # Escapes must be double escaped.
> printf '%s' "\
> cat /dev/zero
> -cksum --version; yes \"${dev_null_hash}\" | cksum --check
> +cksum --version; yes '${dev_null_hash}' | cksum --check
> comm -z /dev/zero /dev/zero
> cut -z -c1- /dev/zero
> cut -z -f1- /dev/zero
Thanks for the review. I pushed it with those 2 changes [1].
Collin
[1]
https://github.com/coreutils/coreutils/commit/3621ad2f71efeeefa5801707e49e319b84c4672c
